[Basic UI] Fix proxy calls for sitemaps created through the UI #860
Conversation
bigbasec
force-pushed
the
sitemap_and_proxy_changes
branch
from
156e661 to
2a8e15e
Compare
...s/org.openhab.ui.basic/src/main/java/org/openhab/ui/basic/internal/render/ImageRenderer.java
Outdated
Show resolved
Hide resolved
...s/org.openhab.ui.basic/src/main/java/org/openhab/ui/basic/internal/render/VideoRenderer.java
Outdated
Show resolved
Hide resolved
...es/org.openhab.ui.basic/src/main/java/org/openhab/ui/basic/internal/render/TextRenderer.java
Outdated
Show resolved
Hide resolved
...s/org.openhab.ui.basic/src/main/java/org/openhab/ui/basic/internal/render/ImageRenderer.java
Outdated
Show resolved
Hide resolved
bigbasec
force-pushed
the
sitemap_and_proxy_changes
branch
from
f807758 to
71adb71
Compare
...s/org.openhab.ui.basic/src/main/java/org/openhab/ui/basic/internal/render/ImageRenderer.java
Outdated
Show resolved
Hide resolved
...es/org.openhab.ui.basic/src/main/java/org/openhab/ui/basic/internal/render/TextRenderer.java
Outdated
Show resolved
Hide resolved
…nts to the proxy call Signed-off-by: Brian Homeyer <bhomeyer@gmail.com>
Signed-off-by: Brian Homeyer <bhomeyer@gmail.com>
Signed-off-by: Brian Homeyer <bhomeyer@gmail.com>
Signed-off-by: Brian Homeyer <bhomeyer@gmail.com>
bigbasec
force-pushed
the
sitemap_and_proxy_changes
branch
from
40e512d to
88b7621
Compare
Just a heads up here, this won't fix the proxy part of things, it just fixes the rendering for the widgets. openhab/openhab-core#2162 would resolve the proxy side so things actually work. |
|
@bigbasec are there dependencies between these PR i.e. should we wait for the others to be merged first? |
This won't have any effect on a system that doesn't have the core PR, no. The only 2 widgets that use the "sitemap" variable are Image and Video, and those are also the only 2 that need the proxy. So no, putting this in won't affect anything, but alone it won't fix the images and videos. |
Dependencies have been merged. |
Signed-off-by: Brian Homeyer <bhomeyer@gmail.com>
bigbasec
force-pushed
the
sitemap_and_proxy_changes
branch
from
3ae6ae7 to
a68c8d6
Compare
|
Getting the hang of this git thing. That should resolve the build issue. |
|
Anything I need to do here to get this merged in? Although there wasn't any dependency on this from the core, this is required to get the core working again. Explained here : openhab/openhab-core#2178 |
kaikreuzer
changed the title
* Passes sitemap to the renderers for proper display and makes adjustments to the proxy call Signed-off-by: Brian Homeyer <bhomeyer@gmail.com>
kaikreuzer
added
the
patch
This is a change to the way basic ui looks up sitemap names for Image and Video types(and any other future types that utilize the proxy).
PR for the core.proxy service is here : openhab/openhab-core#2162
Description of issues covered by this :
https://community.openhab.org/t/images-video-sitemaps-and-proxy/115677